Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): bashisms.yml. again. will work all the time this time i swear. #715

Merged

Conversation

adamperkowski
Copy link
Collaborator

@adamperkowski adamperkowski commented Oct 1, 2024

Type of Change

  • Bug fix
  • Hotfix

Description

Yeah so changed a bit here.

  1. Does not use GitHub Output to store the list now (this was the main issue here), instead creates a file
  2. Still uses GitHub Output for storing a bool
  3. It's now easier to debug beacause the list is being echoed
  4. The file is being removed at the end

And yeah that's about it. Will work now.
Still, it'd be much better to just grap the checkbashisms binary but Debian doesn't seem to care.

Testing

I waste too much time testing workflows. GitHub should make that easier somehow. (yes, it's tested)

Additional Information

Any additional information that reviewers should be aware of? Nope, not here.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • My changes generate no errors/warnings/merge conflicts.

Oopsie forgot about resolves #711

@adamperkowski
Copy link
Collaborator Author

Oh and here you go:
https://github.com/adamperkowski/linutil/pull/11/checks
You can click the little commit hash on the left to see the proregress.

@ChrisTitusTech ChrisTitusTech merged commit 9ffa352 into ChrisTitusTech:main Oct 2, 2024
@adamperkowski adamperkowski deleted the bashisms_ci_strikes_again branch October 2, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Bashism Unit test isn't working
2 participants